[qtbase] Add support for building with OpenGL ES 3.0 #36407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neumann-A
reviewed
Jan 27, 2024
fwcd
force-pushed
the
opengl-gles3
branch
2 times, most recently
from
cb630ec
to
595cffd
Compare
jimwang118
added
the
category:port-feature
|
This feature passed with following triplets: |
m-kuhn
reviewed
Jan 29, 2024
| "name": "qtbase", | ||
| "default-features": false, | ||
| "features": [ | ||
| "gles2" |
There was a problem hiding this comment.
You mention ios in the description, I had troubles building for ios with gles2 in the past (see https://codereview.qt-project.org/c/qt/qtbase/+/458413), is this issue solved?
There was a problem hiding this comment.
Yes, I could solve pretty much this exact issue by adding the gles3 feature.
|
FTR: gles is deprecated on iOS https://developer.apple.com/library/archive/documentation/3DDrawing/Conceptual/OpenGLES_ProgrammingGuide/AdoptingOpenGLES3/AdoptingOpenGLES3.html, so it's correct to not put this into default features. |
|
Can you resolve conflicts? |
jimwang118
removed
the
info:reviewed
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
fwcd
added a commit
to fwcd/vcpkg
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for building Qt with OpenGL ES 3.0, a necessity to build many OpenGL apps for iOS.
Implementation note
The implementation follows the way the GL ES features are structured in the
configurescript, namely by implyinggles2and enablinggles3only via a feature flag:Checklist
./vcpkg x-add-version --alland committing the result.